House Ads Progress

Intro

HouseAds components are in a varrying state of completeness. This document attempts to clearly and concisely define areas that need attention while also making the steps remaining clear. I've attempted out outline clear risks that we may want to consider mitigation on NOW rather than later.

APIs should have special care taken for them as they were a rush project. They were ignored for far too long with no assignment or ownership taken and they languished as a result.

Terminology:

MMBE = Mystery Machine BackEnd (not cheerios)

FE = Mystery Machine

General incomplete Features:

• Edit (new) - Save Ad (AKA create unscheduled ad)
• Preview - Submit Ad (AKA complete ad)
• Delete Ad
• Duplicate/Edit/Preview existing
  • the staging of data on the front end for this is done. the submission plan is not.
• Finalization and validation of MMBE APIs
• MMBE API for ad saving is incomplete, including uploading the asset information.
• Sitehub API
• Sitehub Fallback Ads
• Sitehub adjustments for APIs.

This looks like a long list, but hopefully it isn't in reality. I've just broken down each feature as discretely as possible.

Website:

HA-133 Cheerios File Upload:

1 - I suspect this will take docker work to mount the hard dir into the mm container

HA-66 Home:

1 - Delete API call is not made.

1 - Delete API is quetionable

1 - Duplicate functions as if it were a normal edit. Forwards to template which doesn't make sense IMO. We probably just want to pass data with the ID's and UIDs stripped and have edit key on empty IDs

HA-72 Preview:

1 - Submit needs to actually make the api call.

1 - API for submission is questionable.

HA-76 Template:

3 - Slow loading is a bad UX.

3 - Filters force the object to reload.

2 - Filters are unresponsive until DOM completes loading

HA-80 Edit:

5 - Page retains old data and preloads that before loading current. is mildly jarring

1 - Submission does not occur.

1 - API For submisision is questionable

• The file uploaded as the asset should be the key-value pair of template text value -> new text value. This is inconsistent with some old documentation. As of my exit, this change has already been planned but not tested or prototyped.

General:

• Edgecast URL is stubbed in right now and needs to be obtained from the data itself or somewhere else.

• Logo will require a change in the template files as they stand.

• Date inputs are inconsistent in formatting Validate that the dates submitted mean what we think.

Sitehub:

1 - APIs are incomplete. There are 3 requred: 2 GET, 1 POST

Get are defined here: http://dc-gitrepo-01.ntn.com/kbungo/local_ad_manager/tree/master/server#sitehub-aggregate

POST is roughly defined here: https://jira.buzztime.com/projects/HA/issues/HA-85

1 - HouseAds still has URI stubbing in place for dev use.

1 - fallback ads do not exist and will need to be massaged into the app before release